Skip to content

feat: add DspClient scaffold and pipeline e2e test structure#930

Open
Slowlybomb wants to merge 4 commits into
opendatahub-io:mainfrom
Slowlybomb:e2e-test-reusable-pipelines-RHOAIENG-43403
Open

feat: add DspClient scaffold and pipeline e2e test structure#930
Slowlybomb wants to merge 4 commits into
opendatahub-io:mainfrom
Slowlybomb:e2e-test-reusable-pipelines-RHOAIENG-43403

Conversation

@Slowlybomb

@Slowlybomb Slowlybomb commented Jun 23, 2026

Copy link
Copy Markdown

Summary

  • Fix DSP env var typo (dspRoutURL -> dspRouteURL) in tests/common/environment.go
  • Implement DspClient HTTP wrapper for KFP v2beta1 REST API in tests/common/support/dsp_client.go
  • Add 11 unit tests for DspClient using httptest mock servers
  • Scaffold tests/pipelines/ package with SFT test skeleton

Ref: RHOAIENG-43403

Note

The SFT test skeleton references resources/sft_pipeline.yaml which does not exist yet — compiled pipeline YAMLs from the pipelines repo are needed before the e2e tests can run.

Test plan

  • go test ./tests/common/support/... -run TestDsp — 11 unit tests pass
  • go build ./tests/pipelines/... — builds clean
  • go vet — no issues
  • golangci-lint — 0 issues
  • verify-imports — pass

Made with Cursor

Fiona-Waters and others added 3 commits June 10, 2026 14:11
@Fiona-Waters @Slowlybomb
Add E2E for GRPO/Art training hub implementation
68132c3 
Signed-off-by: Fiona-Waters <fiwaters6@gmail.com>
@Slowlybomb
Add GRPO training test and enhance GRPO notebook
ec8a9e2 
- Introduced TestGrpoTrainingHubMultiNodeMultiGPU to validate GRPO training with multiple nodes and GPUs.
- Updated grpo.ipynb to clarify SDK installation and added checkpoint verification and metrics logging checks for improved robustness.

Tested

Signed-off-by: Slowlybomb <hslyusar@redhat.com>
@Slowlybomb
feat: add DspClient scaffold and pipeline e2e test structure
f07776a 
RHOAIENG-43403: Spike to investigate e2e testing for reusable KFP pipelines.

- Fix DSP env var typo (dspRoutURL -> dspRouteURL) in environment.go
- Implement DspClient HTTP wrapper for KFP v2beta1 REST API
  (upload pipeline, create run, poll status, get details, delete)
- Add unit tests for DspClient using httptest mock servers
- Scaffold tests/pipelines/ package with SFT test skeleton

Signed-off-by: Slowlybomb <hslyusar@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szaher for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • WIP
  • DO NOT MERGE

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 875954cd-58de-4141-a1f5-9f6a0e62fded

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Slowlybomb Slowlybomb marked this pull request as ready for review June 23, 2026 15:00
@openshift-ci openshift-ci Bot requested review from chipspeak and szaher June 23, 2026 15:00
@Slowlybomb Slowlybomb changed the title WIP: feat: add DspClient scaffold and pipeline e2e test structure feat: add DspClient scaffold and pipeline e2e test structure Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chipspeak chipspeak Awaiting requested review from chipspeak
@szaher szaher Awaiting requested review from szaher

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Slowlybomb @Fiona-Waters